Invalid DBC syntax: 'BA_REL_ "GenSigComment" BU_SG_REL_ ICCM_CE SG_ 569 SomeString >!<"";': Expected positive integer." about cantools HOT 6 CLOSED

Almost anything is possible. Can you provide a DBC-file I can use for testing, to make sure the implementaiton works?

from cantools.

I am afraid I am not allowed to give out the original DBC file. And I don't know enough about DBCs to produce my own file. Maybe you can point me in the right directions so I can make the changes myself?

from cantools.

Have a look here: https://github.com/eerimoq/cantools/blob/master/cantools/db/formats/dbc.py#L305-L313

That's the part of the grammar where your DBC fails. Looks like the grammar should not only allow positive integers?

from cantools.

I suggest that you add the failing DBC-line here: https://github.com/eerimoq/cantools/blob/master/tests/files/foobar.dbc#L83

And then modify the tests in tests/test_cantools.py to make them pass. Depending on the side effects on allowing the new grammar, this is likely very little work and ensures that this DBC syntax will not break in the future. See the README for details on how to run the tests locally.

from cantools.

my database is like this：
BA_DEF_ BU_ "NmStationAddress" HEX 0 0;
1 BA_DEF_ BU_ "NodeLayerModules" STRING ;
1811 BA_DEF_REL_ BU_BO_REL_ "GenMsgCycleTimeFast" INT 0 65535;
1 BA_DEF_REL_ BU_BO_REL_ "GenMsgNrOfRepetition" INT 0 65535;
2 BA_DEF_REL_ BU_BO_REL_ "GenMsgDelayTime" INT 0 65535;
3 BA_DEF_REL_ BU_BO_REL_ "GenMsgStartDelayTime" INT 0 65535;
4 BA_DEF_DEF_ "BusType" "";
5 BA_DEF_DEF_REL_ "GenMsgCycleTimeFast" 0;

so：i change the code to：
attribute_definition_rel = Sequence(
'BA_DEF_REL_',
Optional(choice('BU_SG_REL_','BU_BO_REL_')),
'STRING',
'WORD',
choice(DelimitedList('STRING'), OneOrMore('NUMBER')),
';')

now：it is ok

from cantools.

I've modify it the dbc.py file to the following:
attribute_definition_rel = Sequence(
'BA_DEF_REL_',
Optional(choice('BU_SG_REL_', 'BU_BO_REL_')),
'STRING',
'WORD',
Optional(choice(DelimitedList('STRING'), OneOrMore('NUMBER'))),
';')

to support a dbc that looks like this:
BA_DEF_REL_ BU_BO_REL_ "Frame1" STRING ;
BA_DEF_REL_ BU_BO_REL_ "Frame2" HEX 0 1407;
BA_DEF_REL_ BU_BO_REL_ "Event1" INT 10 10000;
BA_DEF_REL_ BU_SG_REL_ "Signal1" ENUM "Yes","No";

from cantools.