No build system about bitcoinpaperwallet HOT 5 CLOSED

Hi,

Thanks for the nudge. When the dust settles on my project (e.g. after I fold in BIP38 etc.) I'll definitely look into learning Grunt and re-deploy as a build. Right now I actually just hack a single HTML file -- I don't have a secret source directory that I keep to myself.

I know bitcoinpaperwallet uses a good chunk of bitaddress' code -- bitaddress has a nice Grunt-based build system whereas bitcoinpaperwallet just uses one flat file. To make it easier for others to add functionality, would you consider offering a src directory alongside the flat file?

—
Reply to this email directly or view it on GitHub.

Canton Becker
[email protected] • (505) 570-0635 • http://cantonbecker.com

from bitcoinpaperwallet.

Would you be open to a pull request for BIP38 support?

from bitcoinpaperwallet.

Possibly! It would be much appreciated. However I've got a few special requirements for my wallet which are slowing me down.

(1) If someone opts for BIP38, I want to present them with a strongly worded warning/caution about how this probably isn't a good idea when giving gifts, how if you lose your passphrase you lose your coins, and how not all wallets support importing BIP38 keys yet so they may need intermediate software to decode their private key before importing into private wallets. (Not very user friendly.)

(2) I think I'm going to need to have the text on the front of the design that says, "Wallet Import Format" be rendered by CSS/HTML and not be a part of the image JPG itself, because this would have to change depending on the output method.

I do worry about rushing into this. On the bitaddress.org discussion, someone was claiming that their browser was inconsistently able to decode a copy/pasted BIP38. I'm not sure what the resolution of that was.

Would you be open to a pull request for BIP38 support?

—
Reply to this email directly or view it on GitHub.

Canton Becker
[email protected] • (505) 570-0635 • http://cantonbecker.com

from bitcoinpaperwallet.

Alrighty. I've sort of 'hacked in' BIP38 so far (ie it's correctly generating the privkeys but not displaying very nicely), but I'd really prefer for a build system to be implemented first just out of good design practices, so I'll hold off on implementing BIP38 fully in its current state. That is part of the issue I ran into is not being able to change the text without changing the JPG.

If this is on your 'todo list' then great -- if you'd prefer that someone else implement it, let me know -- happy to do so once a build system is in place. I just worry about copy-pasting stuff in from bitaddress.org as it feels messy and easy to miss small things.

from bitcoinpaperwallet.

Not looking great, but the functionality is there at a basic level.

from bitcoinpaperwallet.