Bacon fails on a workspace with inter-member dependencies on Windows about bacon HOT 5 CLOSED

This seems to be related: rust-lang/cargo#6198

Checked on my machine and the metadata command invoked is

cargo metadata --format-version 1 --manifest-path \\?\C:\Users\<stuff...>\bacon-repro\Cargo.toml

which fails because in the end it does not normalize "bacon-repro/crate-b/../crate-a" to "bacon-repro/crate-a". If I manually invoke metadata with --manifest-path ./Cargo.toml then it works.

from bacon.

I got the same

from bacon.

More investigating: it works for me if I remove this canonicalize call. I'm not sure when it is needed - I suppose it changes what Cargo.toml would be resolved in presence of symlinks, but I don't know if that matches other rust tools. I checked what rust-analyzer is doing and it seems that it just uses non-normalized paths. So maybe we can just remove that call?

I guess another option would be to use cargo metadata itself for resolving this, as it also has the logic to find a Cargo.toml somewhere in parent chain. I think you can run it in the directory given to bacon and it will tell you either a package or a workspace it resolved.

from bacon.

I'm not answering because at work today but I'm following the investigation with interest.

from bacon.

I confirm there doesn't seem to be any problem on linux.

from bacon.