Comments (7)
The AIO requirement is documented in README.md in this repo -- I can add a note in the dqlite, go-dqlite, and lxd repos as well.
The specific error here is a null pointer dereference because something in the call stack of dqlite_node_create doesn't set the errmsg field we try to use a nonexistent struct dqlite_node
. I'll fix that, and then the feedback when running without AIO support should be better.
from raft.
Error message should now be something like:
Error: create node: failed to create node: internal dqlite error
Not the greatest, but better than a panic. Maybe it would be a good idea to modify dqlite_node_create
to allow returning an error string (using some other channel than the errmsg
field of struct dqlite_node
)? Then we wouldn't have to interpret the rather non-specific return code in go-dqlite.
from raft.
That seems reasonable to me. I assume the current behavior (clearing the
struct dqlite_node
) is defense in depth against callers who neglect to check for errors -- maybe we could address that concern in some other way.
I don't think there's a particular reason for the current behavior. As long as we document that dqlite_node_destroy()
, must always be called, even in case of errors, we should be good and don't need to do anything special.
The idiomatic way would be something like:
int rc;
dqlite* node;
rc = dqlite_node_create(..., &node);
if (rc != 0) {
if (rc == DQLITE_NOMEM) {
printf("out of memory\n");
} else {
printf("%s\n", dqlite_node_errmsg(node));
dqlite_node_destroy(node)
}
exit(-1); /* or whatever */
}
from raft.
Now that the AIO requirement is documented everywhere and the go-dqlite error message is fixed (see canonical/go-dqlite#199) I think this can be closed?
from raft.
Error message should now be something like:
Error: create node: failed to create node: internal dqlite error
Not the greatest, but better than a panic. Maybe it would be a good idea to modify
dqlite_node_create
to allow returning an error string (using some other channel than theerrmsg
field ofstruct dqlite_node
)? Then we wouldn't have to interpret the rather non-specific return code in go-dqlite.
What do you think of changing the behavior of dqlite_node_create()
so that even if it returns an error, it does not free the dqlite_node **n
pointer, so call sites can invoke dqlite_node_errmsg()
to extract the error message, and then call dqlite_node_destroy()
to free the memory.
The only exception to the above behavior would perhaps be if dqlite_node_create
fails with DQLITE_NOMEM
, but it's a minor detail practically speaking, probably something we don't need to worry too much in real world.
from raft.
That seems reasonable to me. I assume the current behavior (clearing the struct dqlite_node
) is defense in depth against callers who neglect to check for errors -- maybe we could address that concern in some other way.
from raft.
from raft.
Related Issues (20)
- missing getrandom on centos 7 HOT 1
- [question] Usage of raft_add, raft_remove, and raft_assign HOT 2
- [question] When is the first leader elected? HOT 2
- recvAppendEntries: Assertion `r->state == RAFT_FOLLOWER || r->state == RAFT_CANDIDATE` failed HOT 9
- [question] Forwarding request to leader HOT 8
- Potential use-after-free in handling of raft_transfer HOT 5
- Fix the 32-bit CI HOT 1
- can't build on m1 mac (`<linux/xxxxx.h>` is missing) HOT 3
- v1.x RFC: pull based approach HOT 5
- raft_start(): io: closed segment xxx is past last snapshot xxx HOT 4
- [question] Understanding how to add new servers HOT 15
- ./configure fails when no external dependency is found HOT 4
- Assertion: src/uv_truncate.c:168: UvTruncate: Assertion `index < uv->append_next_index' failed. HOT 3
- src/replication.c:457: getRequest: Assertion `req->type == type' failed. HOT 3
- Segment writes blocked when taking a snapshot. HOT 3
- src/log.c:87: refsTryInsert: Assertion `next_slot->term != term' failed. HOT 9
- Jepsen: Another truncate-related assertion failure
- [suggestion] add lock/unlock function pointers to raft_io (and use them) HOT 1
- `uvOsFallocateEmulation` taking too long time HOT 1
- CI: `xfs` test failures HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raft.