Code Monkey home page Code Monkey logo

Comments (8)

MathieuBordere avatar MathieuBordere commented on August 23, 2024

Thanks for logging this issue, good catch!

The quorum logic should implement the part in Rules for Servers - Leaders at the bottom of figure 2 in raft extended

If there exists an N such that N > commitIndex, 
a majority of matchIndex[i] ≥ N, 
and log[N].term == currentTerm 
: set commitIndex = N.

This does not seem to be the case in our implementation.

from raft.

calvin2021y avatar calvin2021y commented on August 23, 2024

Any plan to fix this?

from raft.

MathieuBordere avatar MathieuBordere commented on August 23, 2024

Yes, it is still the plan to fix this.

from raft.

calvin2021y avatar calvin2021y commented on August 23, 2024

This bugs find almost a year, Is there a schedule plan for it.

from raft.

MathieuBordere avatar MathieuBordere commented on August 23, 2024

I have a branch where I'm implementing a fix as it has some unintended consequences in dqlite, however, unfortunately, things keep coming up in between to finish it.

from raft.

calvin2021y avatar calvin2021y commented on August 23, 2024

Thanks for the quick response, look forward to it.

If you can share your branch here, we can try it and maybe give some advice.

from raft.

MathieuBordere avatar MathieuBordere commented on August 23, 2024

https://github.com/MathieuBordere/raft/commits/quorum-bugfix it's behind the current master somewhat though.

from raft.

cole-miller avatar cole-miller commented on August 23, 2024

I'm in the process of picking up Mathieu's previous work on this, will have a draft PR up soon.

from raft.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.