Code Monkey home page Code Monkey logo

Comments (1)

ca-scribner avatar ca-scribner commented on September 26, 2024

To implement this, we'd need something like:

# Note: get_layer is no longer decorated with @abstractmethod, so that someone doesn't need to subclass things at all
def get_layer(self) -> List[Layer]:
  """Pebble configuration layer for the container.

  Override this method with your own layer configuration.
  """
  return []
  
def _update_layer(self):
  """Updates the Pebble layer for this component, re-planning the services afterward."""
  container = self._charm.unit.get_container(self.container_name)
  new_layers = self.get_layer()
  # For backward compatibility, handle when self.get_layer() returns a single Layer
  if not isinstance(new_layers, Iterable):
    new_layers = [new_layers]

  original_plan = container.get_plan()

  for new_layer in new_layers:
    container.add_layer(new_layer)

  if original_plan.services != container.get_plan():
    container.replan()

where we handle the old version of get_layer() returning a single layer, and loop through the layers then decide at the end of a replan is needed

from charmed-kubeflow-chisme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.