Comments (2)
justinbmeyer
commented on May 30, 2024
@nlundquist Thinking about this a bit, is it a feature that .preventDefault() is not called? If an error happens in someone's routing code (within the call to history.pushstate()) the app is very likely in a broken state. Would it be better on average to do a full reload?
Is the problem that this situation is very hard to debug?
from can-route-pushstate.
nlundquist
commented on May 30, 2024
I agree the behavior is a nice fallback in production, but the reload it introduces is very noticeable and hard to debug. I think it should fail fast when in a development build.
In Ting's case this exception was being caught at some point in the CanJS call stack, so even preserving the log between reloads or breaking at navigation didn't reveal anything.
from can-route-pushstate.
Related Issues (20)
- An in-range update of can-simple-observable is breaking the build 🚨 HOT 5
- An in-range update of can-define is breaking the build 🚨 HOT 18
- An in-range update of can-dom-events is breaking the build 🚨 HOT 3
- An in-range update of can-queues is breaking the build 🚨 HOT 4
- Documentation Updates
- The Pushstate constructor should work independent of can-route
- Documentation Improvements
- Removal of keepHash.
- Docco notes HOT 14
- When used with SSR
- Remove highlight.js workaround
- An in-range update of can-route is breaking the build 🚨 HOT 2
- An in-range update of can-reflect is breaking the build 🚨 HOT 2
- An in-range update of can-assign is breaking the build 🚨 HOT 2
- An in-range update of can-dom-events is breaking the build 🚨 HOT 2
- An in-range update of can-globals is breaking the build 🚨 HOT 1
- An in-range update of can-map is breaking the build 🚨 HOT 3
- An in-range update of can-queues is breaking the build 🚨 HOT 1
- route.data DefineMap - Include defaults HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from can-route-pushstate.