Magic Itens don't add Saving Throws bonuses about dungeon-sheets HOT 3 CLOSED

Thanks for submitting this issue and including a way to fix it. I fixed the master branch, but haven't updated PyPI yet.

It occurred to me that this is all or nothing: you can't have a magic item that, for example, grants +1 to strength saving throws only. I'm not sure if that's a problem or not. @bw-mutley: are you aware of any magic items that grant bonuses to only some saving throws?

from dungeon-sheets.

Hi there, @canismarko , I am glad to be of help.

are you aware of any magic items that grant bonuses to only some saving throws?

I use only Tasha's and DMG in my sessions, and don't recall of any items wich would add only to a specific saving throw. But I'm aware of many magic items which add to DC dificult of spellcasters. Anyway, a more flexible approach to this problem would be to add a _magic_items_bonuses method to Character class which would parse them all.

...but haven't updated PyPI yet.

Maybe it is better this way, I have more enhancements in mind. Some of them are mentioned here: #92 . But also, for a better use of M. Savage template, I've come to some others, one of them is to simplify the display of proficiencies, separating them as armor, weapon and tools. I am planning to work on it next saturday.

from dungeon-sheets.

Anyway, a more flexible approach to this problem would be to add a _magic_items_bonuses method to Character class which would parse them all.

I think we'll eventually need some property on the magic item itself that gets called at the right time. Something like Amulet of the Devout from Tasha's seems like it needs even more flexibility than _magic_item_bonuses could provide. I'm going to open a new issue for this.

from dungeon-sheets.