Drop MetaWhere support about cancancan HOT 13 CLOSED

Sounds good

from cancancan.

I definitely think we should drop meta_where support in favour of just supporting AREL conditions. This would be a breaking change though and have to be wrapped up in a 2.0 release, which I'm not quite prepared to do yet (most due to #14).

I will keep this open as you've already done most of the hard work of identifying what can be pulled out.

Thanks!

from cancancan.

What about switching to support squeel?
If it helps, I've done some integration ages ago.

from cancancan.

Squeel has many problems with ActiveRecord 4 when dealing with complex queries and I think it's not actively devloped any more

from cancancan.

I love squeel as well, but I don't think its support should be baked into CanCanCan. I would like to make sure CanCanCan accepts AREL conditions... so you can choose to use Squeel if you want, but not have to support it directly in this library.

from cancancan.

@bryanrite Fair enough. I like Squeel a lot, but baking in support for it was never a popular feature anyway.

from cancancan.

I do not completely agree. Looks like squeel is still supported, isn't it? And since I do not see many alternatives, I would like to switch to it. @legendetm why do you say that it has many issues?
I agree in dropping MetaWhere support, anyway.

from cancancan.

At the time when I wrote the comment, squeel had many bugs with ActiveRecord 4 for a long period. Now squeel has new maintainer who has fixed those problems.

from cancancan.

I don't think we need to support Squeel in Cancancan core, if a project has Squeel in it, they can specify Squeel conditions in scopes which can be used in the ability file. Building a DSL for Squeel in Cancancan, at least the core, doesn't feel right to me. I could start a cancancan-squeel project under CanCanCommunity if anyone wanted to tackle it that way?

from cancancan.

I agree with you @bryanrite. A cancancan-squeel project separated from the core looks like a good solution.

from cancancan.

Has anyone managed to get Cancancan working with Squeel on Rails 4.2? I've used this gist and have my ability tests working, but I'm getting a load of missing column & table errors when I load_and_authorize_resources in my controllers. So I suspect there's some change to Rails which means ControllerResource needs changing. Any ideas or guidance would be great. Thanks.

from cancancan.

Another option is to replace metawhere with ransack support, which has almost the same syntax.
Having an easy serializable format for more advanced rules is definitely important if you want to store rules in the database.

from cancancan.

Gone

from cancancan.