Code Monkey home page Code Monkey logo

Comments (5)

Crystark avatar Crystark commented on May 8, 2024

After some testing, it seems the problem originates in active_record_adapter.rb#L104. .includes doesn't seem to work.

I've forked the project and tried to use joins, which works. It seems the tests do not pass though. I wonder if it's just a matter of the active record version. The gemfile uses AR 3 and i'm using AR 4.

I see the gemfiles for testing are generated by appraisal and i wouldn't know how that works and how to add a rails 4 test.

from cancancan.

bryanrite avatar bryanrite commented on May 8, 2024

Yah, this is an AR3 vs AR4 issue... unfortunately CanCan was built using supermodel and with_model which only work on rails <= 3.0.

I'm currently trying to find time to remove those dev dependancies so I can have a proper rails 3.1, 3.2, 4.0, and 4.1 test suites... 4.0 should work no problem with some deprecations, 4.1 will likely have some issues until I can get that tested and updated.

from cancancan.

bryanrite avatar bryanrite commented on May 8, 2024

See #14

from cancancan.

Crystark avatar Crystark commented on May 8, 2024

Thanks, i will keep a close eye on this.

from cancancan.

bryanrite avatar bryanrite commented on May 8, 2024

Closing this as it was included in #97.

from cancancan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.