Comments (5)
After some testing, it seems the problem originates in active_record_adapter.rb#L104. .includes
doesn't seem to work.
I've forked the project and tried to use joins, which works. It seems the tests do not pass though. I wonder if it's just a matter of the active record version. The gemfile uses AR 3 and i'm using AR 4.
I see the gemfiles for testing are generated by appraisal and i wouldn't know how that works and how to add a rails 4 test.
from cancancan.
Yah, this is an AR3 vs AR4 issue... unfortunately CanCan was built using supermodel
and with_model
which only work on rails <= 3.0.
I'm currently trying to find time to remove those dev dependancies so I can have a proper rails 3.1, 3.2, 4.0, and 4.1 test suites... 4.0 should work no problem with some deprecations, 4.1 will likely have some issues until I can get that tested and updated.
from cancancan.
See #14
from cancancan.
Thanks, i will keep a close eye on this.
from cancancan.
Closing this as it was included in #97.
from cancancan.
Related Issues (20)
- Running dangerous :show permission when the resource name is passed and mismatch the controller name HOT 3
- Polymorphic associations do not support computing the class HOT 12
- STI normalizer fails when existing rule conditions are relation HOT 2
- undefined method `#{parent_name}=' for singleton associations
- Nil values on enums fails to authorize
- Gemspec does not have Rails version dependency for various version of the gem
- cancancan is chaninging my get request ID HOT 1
- Deep conditions nesting on sqlite => stack overflow
- Selective permissions on STI sub-classes not respected by accessible_by HOT 1
- Granting read permission on intermediate STI table prevents any records being returned HOT 4
- inconsistent behaviour with Hash subjects
- `can?` unnecessarily loads relationships in memory when it could leverage `accessible_by` HOT 1
- can? should return false when there are no attributes that the current user can perform action on
- Possible breaking change with handling of `nil` conditions in 3.5.0
- How to define ability action name that is same as the default action aliases?
- Why are merged rules still bound to the merged Ability class?
- Extra table alias is being generated, but then ignored in the final stage of an accessible_by query HOT 1
- Creating resource failes when association is polymorphic and singleton.
- Can't apply rules to `create` action without affecting `new` because of aliasing HOT 12
- Resource Loader gets ignored with Whitespace-Only ID in URL (e.g., "\n")
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cancancan.