Code Monkey home page Code Monkey logo

Comments (4)

CalebBell avatar CalebBell commented on September 24, 2024 1

Hi Yoel,

All the data is nominally at 298.15 K.
As you surmise, I would prefer to keep the phase data separate in chemicals.
Reconciling the phase data is really great stuff; it's just a lot of work and it's never all done, there is always more work left to do.

from chemicals.

yoelcortes avatar yoelcortes commented on September 24, 2024

Great, I'll take the lead on this one. No worries if you can't get back to me so quickly, your expertise is really helpful and I'm happy that you can still engage yourself in open-source projects like these. I think I'll plan on the following functions:

# This one tries to find any heat of formation, regardless of phase.
# If you prefer, we don't need to implement this one in `chemicals`
# since it just uses the other lookup methods (I can implement it in `thermosteam`)
Hf(CASRN) # -> J/mol, phase 

# `Hf` will call these functions internally until any one is found
# These should be implemented in `chemicals`.
Hfs(CASRN) # -> J/mol
Hfl(CASRN) # -> J/mol
Hfg(CASRN) # -> J/mol

# BioSTEAM's Chemical object will use this one to
# help calculate the heat of formation in the reference phase.
dH_phase(self, T, current_phase, new_phase) # -> J/mol

So the way BioSTEAM would set the heat of formation of a chemical is as follows:

Hf, phase = heat_of_formation(CAS) # Using an alias
self.Hf = Hf + self.dH_phase(298.15, phase, self.phase_ref)

I'll work on this next.

from chemicals.

yoelcortes avatar yoelcortes commented on September 24, 2024

Ahh, I was also meaning to ask, do you know what conditions are our data tables? I know literature reports data at 0, 20, and 25 C. I can also check the literature sources, but I'm not sure where to find them...

from chemicals.

CalebBell avatar CalebBell commented on September 24, 2024

This was great a job you did Yoel! I really appreciate it.

from chemicals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.