Comments (4)
Should be fixed after #74.
from forwardproxy.
Ah yeah, sorry about this. We didn't know this would be a breaking change, as Go recently introduced the http.ResponseController
type. So instead of type-asserting, module code now needs to use ResponseController to flush, etc. (Should be an easy change at least. Again, sorry, this one surprised us.)
from forwardproxy.
Replace type-asserting to ResponseController simply, Caddy doesn't log "ResponseWriter doesn't implement http.Flusher" error, but still can't connected to website througth HTTPS proxy server.
--- old/forwardproxy/forwardproxy.go 2023-08-18 16:29:35.315551349 +0800
+++ new/forwardproxy/forwardproxy.go 2023-08-18 16:27:56.808116573 +0800
@@ -309,13 +309,12 @@ func (h *Handler) ServeHTTP(w http.Respo
fallthrough
case 3:
defer r.Body.Close()
- wFlusher, ok := w.(http.Flusher)
- if !ok {
- return caddyhttp.Error(http.StatusInternalServerError,
- fmt.Errorf("ResponseWriter doesn't implement http.Flusher"))
- }
+ wController := http.NewResponseController(w)
w.WriteHeader(http.StatusOK)
- wFlusher.Flush()
+ err := wController.Flush()
+ if err != nil {
+ return caddyhttp.Error(http.StatusInternalServerError, fmt.Errorf(err.Error()))
+ }
return dualStream(targetConn, r.Body, w)
}
from forwardproxy.
@jerry-wolf Do you want to try again now with the latest commits?
from forwardproxy.
Related Issues (20)
- Should caddy2 be default branch? HOT 1
- Rationale of :443 in ":443, example.com" HOT 1
- Allow use of wildcard outside of `*.` prefix HOT 5
- Leverage caddy-l4 HOT 7
- Role of probe_resistance HOT 4
- [Feature request] Add custom DNS resolver
- Would using tokio improve performance? HOT 2
- Putty/WinScp HTTP Proxy
- insecure schemes are only allowed to localhost upstreams HOT 1
- Can I us this to add custom request headers? HOT 1
- Network Interface Feature example: fe0 in the dialcontext to be added. HOT 1
- Cannot connect to webrtc normally HOT 2
- Caddy2 support not only 443 port HOT 6
- The caddy2 version bahaves unexpectly. HOT 5
- where the "binaries" at? HOT 1
- "308 Permanent Redirect" HOT 2
- Download not available HOT 2
- Broken link in documentation pointing at blog article HOT 1
- Any change to support Cadddy log function ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forwardproxy.