Code Monkey home page Code Monkey logo

Comments (4)

klzgrad avatar klzgrad commented on June 9, 2024 1

Should be fixed after #74.

from forwardproxy.

mholt avatar mholt commented on June 9, 2024

Ah yeah, sorry about this. We didn't know this would be a breaking change, as Go recently introduced the http.ResponseController type. So instead of type-asserting, module code now needs to use ResponseController to flush, etc. (Should be an easy change at least. Again, sorry, this one surprised us.)

from forwardproxy.

jerry-wolf avatar jerry-wolf commented on June 9, 2024

Replace type-asserting to ResponseController simply, Caddy doesn't log "ResponseWriter doesn't implement http.Flusher" error, but still can't connected to website througth HTTPS proxy server.

--- old/forwardproxy/forwardproxy.go	2023-08-18 16:29:35.315551349 +0800
+++ new/forwardproxy/forwardproxy.go	2023-08-18 16:27:56.808116573 +0800
@@ -309,13 +309,12 @@ func (h *Handler) ServeHTTP(w http.Respo
 			fallthrough
 		case 3:
 			defer r.Body.Close()
-			wFlusher, ok := w.(http.Flusher)
-			if !ok {
-				return caddyhttp.Error(http.StatusInternalServerError,
-					fmt.Errorf("ResponseWriter doesn't implement http.Flusher"))
-			}
+			wController := http.NewResponseController(w)
 			w.WriteHeader(http.StatusOK)
-			wFlusher.Flush()
+			err := wController.Flush()
+			if err != nil {
+				return caddyhttp.Error(http.StatusInternalServerError, fmt.Errorf(err.Error()))
+			}
 			return dualStream(targetConn, r.Body, w)
 		}

from forwardproxy.

mholt avatar mholt commented on June 9, 2024

@jerry-wolf Do you want to try again now with the latest commits?

from forwardproxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.