Code Monkey home page Code Monkey logo

Comments (3)

zanechua avatar zanechua commented on June 22, 2024 4

I have actually managed to complete one that works for version 5, however I don't think it has backward compatibility with version 4.

Do you still want me to do a PR?

Here's the codepen for version 5.
http://codepen.io/zanechua/pen/GozrNe

from videojs-sublime-skin.

commonpike avatar commonpike commented on June 22, 2024 1

That version seems to be pretty perfect as far as I can see !

Almost. It's pretty perfect at 10px. Increase the font size and the controls get out of line.

I bumped into this because I accidently loaded the stylesheet twice, causing IE to apply rules like font-size:1.8em twice on the same element (causing font-size to be 3.24em .. this seems like an ie bug).

from videojs-sublime-skin.

zakj avatar zakj commented on June 22, 2024

Thanks for the kind words! I haven't been following the development of video.js v5, so I'm not sure how much work would go into updating this skin. I'd be happy to review a PR but I can't promise I'll have time to spare on a major effort in the near future.

from videojs-sublime-skin.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.