Code Monkey home page Code Monkey logo

Comments (5)

holgerbrandl avatar holgerbrandl commented on July 26, 2024

Could you provide a PR containing this new element?

from themoviedbapi.

icaronunes avatar icaronunes commented on July 26, 2024

No, I do not have that ability yet.
I tried to look but I did not exist.

from themoviedbapi.

Lundez avatar Lundez commented on July 26, 2024

Hi! Hijacking this old issue. The "credits" doesn't work that well anymore, it only finds the movies that a Person has been a character in. Not TvSeries. Using the combined_credits would fix this, or using the two methods "tv_credits"/"movie_credits" on for each kind.

If you'd like I think I could do this and push. Just put the issue on me and I'll solve it.

See:
https://developers.themoviedb.org/3/people/get-person-combined-credits
https://developers.themoviedb.org/3/people/get-person-movie-credits
https://developers.themoviedb.org/3/people/get-person-tv-credits

from themoviedbapi.

holgerbrandl avatar holgerbrandl commented on July 26, 2024

Hey @Lundez, sure feel welcome to provide a PR. Reflecting the official API seems the best option, that is adding a method for combined-credits (and removing no longer working methods as needed).

from themoviedbapi.

holgerbrandl avatar holgerbrandl commented on July 26, 2024

solved via PR

from themoviedbapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.