Code Monkey home page Code Monkey logo

Comments (3)

Jehan avatar Jehan commented on July 2, 2024

For info, I can see in src/nsSBCSGroupProber.cpp that it has been disabled lines 83-84:

// disable latin2 before latin1 is available, otherwise all latin1
// will be detected as latin2 because of their similarity.
//mProbers[10] = new nsSingleByteCharSetProber(&Latin2HungarianModel);
//mProbers[11] = new nsSingleByteCharSetProber(&Win1250HungarianModel);

I'm unsure why we'd need latin1 (ISO 8859-1) support first. Anyway files in latin1 will be wrongly detected, now they would still be wrongly detected, but in another encoding.
Well anyway, I'll have a closer look, and will investigate if needed.

from uchardet.

Jehan avatar Jehan commented on July 2, 2024

I have added some ISO-8859-1 and ISO-8859-2 test files and now I understand the issue.
Both files are currently detected as WINDOWS-1252. If I activate ISO-8859-2, they both are activated as ISO-8859-2.
The problem is that Windows-1252 is a superset of ISO-8859-1, so it is actually not a completely wrong answer, but it becomes completely wrong once ISO-8859-2 is activated. So let's indeed wait for clear ISO-8859-1 support.

from uchardet.

Jehan avatar Jehan commented on July 2, 2024

Fixed with commit 6832552.

from uchardet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.