Code Monkey home page Code Monkey logo

Comments (2)

sunfishcode avatar sunfishcode commented on September 22, 2024

In the SocketAddrXdp case, it's not intentional. I didn't realize that SocketAddrXdp's file descriptor field means that any function that "dereferences" it would need to be unsafe, like sendto_xdp and sendto_any. That's also the case for io_uring_params and io_uring_setup too. So those are bugs. I'm not yet sure what to do about them.

For PrctlMmMap, the only user is configure_virtual_memory_map, and it's in the category of things where we can't practically describe the lifetime, so we just make it unsafe. We do a similar thing for kevent.

from rustix.

arctic-alpaca avatar arctic-alpaca commented on September 22, 2024

For SocketAddrXdp, the sendmsg and recvmsg implementations in the kernel currently don't make use of the file descriptor or SocketAddrXdp in general. Only the msghdr, in particular the flag(s) (MSG_DONTWAIT) is used.
The AF_XDP docs also show an example for sendto(...) with the sockaddr parameter set to NULL.

As far as I can tell, SocketAddrXdp is only used in the bind method to signal the usage of a shared UMEM.

Could the sendto_xdp, sendto_any (and probably recvmsg too) methods just omit SocketAddrXdp?

from rustix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.