Provide option for not following symlinks about dua-cli HOT 8 CLOSED

I am very sorry to hear that dua did indeed eat your laundry :(! What an oversight, and clearly a result of me being sloppy and trying to save time by not writing crucial tests.

Please update to the latest version, v2.1.8, which doesn't follow symbolic links to directories anymore.

from dua-cli.

I believe there is still something wrong, as I just had dua delete files I did not intend to delete.

from dua-cli.

Can you provide more details? Are the files you don't want to delete also symlinks to folders/files?

from dua-cli.

@vks I absolutely agree, dua must not follow symlinks when deleting files. However, this was fixed in the latest version, and thus it's most important for us to learn which version you were effectively using. If that is indeed the latest one, I would hope you can provide a reproducible example so this (possibly new) issue can be fixed ASAP.
Thank you.

from dua-cli.

I was using a very recent version from my pull request yesterday (3baf7f3 plus updated dependencies).

I still need to investigate what exactly happened and whether I can reproduce it, but dua certainly deleted many more files than I marked. I suspect it is related to symlinks, but it could be something else.

from dua-cli.

After further investigation, I don't think that this was ever fixed correctly. Currently, dua uses path.metadata() when deleting recursively, for which is_symlink always returns false! std::fs::symlink_metadata should be used instead.

from dua-cli.

I hope this is really fixed in 2.1.11, as 2.1.9 ate my stuff again. And it's much worse this time.

from dua-cli.

@crides I believe it is fixed now, but please look at the code yourself. It uses symlink_metadata instead of metadata, so symlink detection should work now.

from dua-cli.