Property property of MemberExpression expected node to be of a type [\"Identifier\"] but instead got null about babel-plugin-functional-hmr HOT 7 CLOSED

Hey @sibelius! Thanks for reporting, I will fix this soon.

from babel-plugin-functional-hmr.

@sibelius Could you provide some more context?

from babel-plugin-functional-hmr.

Getting the same thing. I think I've narrowed it down to the ...props. Seems like it's barfing on the "rest" syntax

from babel-plugin-functional-hmr.

@kylealwyn @sibelius I'm not a JS expert but it seems like invalid syntax to me: AFAIK you can't use spread syntax in a destruct expression (props). Valid syntax would be:

export const Text = ({ style, children, capitalized, props }: Object) =>
  <RNText style={[styles.font, style]} {...props}>
    {capitalized ? capitalizeFirstLetter(children) : children}
  </RNText>;

from babel-plugin-functional-hmr.

In fact, you can

from babel-plugin-functional-hmr.

@sibelius seems like you are way more experienced than me please help me and send a PR with the fix

from babel-plugin-functional-hmr.

@bvic23 The syntax and method is called "rest" parameters: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters

It works the same for arrays as it does with objects. when destructuring, it effectively assigns the rest of the object or array into the variable. take for example:

const obj = {
   a: 1,
   b: 2,
   c: 3,
};

const { a, ...rest } =  obj;
// a is 1 here, rest is { b: 2, c: 3 }

This method works nicely with React because you may only want to pluck a couple properties out of the props arg and pass the rest down to the native view.

I have no experience with babel transforms and it's AST process but I'm happy to help in any way

from babel-plugin-functional-hmr.