Comments (7)
There is an unit test for this feature.
You can even disable the cleanup and check the generated image if the size is correct. Are there any errors or something else shown? Or is it just not creating the correct size?
from cakephp-imagine-plugin.
OK, I can confirm it's an issue which I thought I have resolved.
See php-imagine/Imagine#478 this as well, their support is terrible slow.
from cakephp-imagine-plugin.
But this doesn't seem to be a Imagine problem. The same version of it is used, only the version of this plugin is changed.
from cakephp-imagine-plugin.
I'm more than happy if you can provide a better idea. I think it has something to do with the way the instance is passed around in the ImageProcessor lib vs the Behavior before.
Also, like I write in the ticket, this even happens with their very own tutorial code. Also I had do do the & reference in the old behavior to make this work for some weird reason. I'm pretty sure there is something wrong going on with the instance.
from cakephp-imagine-plugin.
The issue is really weird, the unit tests for it work just fine. I've checked even the generated images manually if the size is really what I expect and it is correct.
from cakephp-imagine-plugin.
@GuidoHendriks I can't do much about this I think.
See https://github.com/avalanche123/Imagine/blob/develop/lib/Imagine/Image/AbstractImage.php#L42
// Won't work
$thumbnail = $this->copy();
// Works
$thumbnail = $this;
Honestly, I have no idea why this was working before, nor why the copy is required here because it's not working when using copy().
from cakephp-imagine-plugin.
@GuidoHendriks please try the 2.x
branch, this commit d21f2e9, should fix the problem. It is still a workaround but I doubt Imagine is going to fix it any time soon. I still don't even understand the exact cause of the issue.
from cakephp-imagine-plugin.
Related Issues (16)
- Autload Problems on *nix machines HOT 3
- Class 'ImagineUtility' not found in ImagineUtilityTest HOT 3
- Installation from composer fails HOT 2
- trying to use this HOT 2
- trying to use this HOT 1
- $useTable = false in Imagine model please
- composer correct installation location HOT 1
- incorrect link in Caching-And-Storage documentation HOT 1
- Docs Page not found HOT 1
- 3.x Install location HOT 4
- ImageProcessor thumbnail() bug
- Too much memory consumption HOT 2
- Cakephp 3.6 compatibility HOT 3
- Error loading dependencies with Composer HOT 4
- Looking for a new maintainer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cakephp-imagine-plugin.