Code Monkey home page Code Monkey logo

Comments (3)

BurntSushi avatar BurntSushi commented on May 31, 2024

I think I agree with your analysis, very nice! I'm working on a regression test now, and then hopefully a fix will be easy.

from chan.

gwillen avatar gwillen commented on May 31, 2024

Awesome, thanks a lot for looking into this. :-) I will note my concern that -- in light of this bug -- there is some code on this path (e.g. the notifier unsubscribe method) which has clearly never been actually exercised, so even after the fix I am concerned about what other bugs may lurk. (I'm not asking you to do anything about that unless it seems like a good use of your time, just pointing it out.) Thanks again!

from chan.

BurntSushi avatar BurntSushi commented on May 31, 2024

@gwillen You should be all set now. The fix is in 0.1.16 on crates.io.

Awesome, thanks a lot for looking into this. :-) I will note my concern that -- in light of this bug -- there is some code on this path (e.g. the notifier unsubscribe method) which has clearly never been actually exercised, so even after the fix I am concerned about what other bugs may lurk. (I'm not asking you to do anything about that unless it seems like a good use of your time, just pointing it out.) Thanks again!

The version number of this library unfortunately reflects its maturity. I think it just doesn't have that many users yet, so there hasn't been much experience actually using this library. I have some applications in mind myself that should stress the implementation more, but it might take me a few months (or more) to get there.

I think at this point, the most valuable thing you could provide is experience using the library. Similarly, input on other issues like this one: #2 would be quite valuable.

from chan.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.