Question about sql_exporter reading the config file about sql_exporter HOT 3 CLOSED

Hey @burningalchemist,

Oooh, Reloader looks like exactly what I want. Though I'm trying the Azure Active Directory authentication approach, as I've asked about in my other open issue, #169. So hopefully I can get that working.

Yeah, it makes sense that you'd have to revisit the codebase and workflow if you introduce a config file watcher. There is probably no point (and probably doesn't make sense) in pursuing this since I'm sure this project has more important priorities. And it really isn't sql_exporter's job to watch for config file changes -- not the purpose of this application.

No worries about being away; you're allowed to have a life outside this software, haha. :)
I assume you're referring to my questions here? Yes, those questions are still relevant. It'd be much appreciated if you could answer them to the best of your ability.
#37 (comment)

from sql_exporter.

@jdstone cool, will do. I'll close this issue for the time being. But I'll take your feedback as a feature request. 👍

from sql_exporter.

Hi @jdstone,

Yeah, you're right. Currently the config file is only read once on startup. What I might suggest as an option is Reloader. It's an additional component, but it solves exactly this type of problems. Please have a look.

At the moment sql_exporter has a straightforward workflow, so introducing a config file watcher requires revisiting the codebase (we need to watch for changes continuously, detect them, drop previously created objects like Exporter->Target->Collector->Query, and recreate them again with a new config, then reconnect).

I'll think about it, but for the time being to unblock you I'd recommend looking at Reloader or any similar solution. Password change is an operational event, so I'd rather make it noticeable for the applications as well.

P.S. I'm sorry, I was away from my computer for some time, so I didn't answer your previous question (regarding jobs). Is it still relevant?

Kind regards,
Sergei

from sql_exporter.