Code Monkey home page Code Monkey logo

Comments (6)

alifeee avatar alifeee commented on August 28, 2024 1

I can add it, if y'all would like.

That would be grand 😊

I think there are many ways to add this. One would be to provide this StrEnum class/subclass in the utils.py file. Of course, the tests would be nice to port over too.

Would you like any guidance? I trust you can make a good change :)

from gspread.

lavigne958 avatar lavigne958 commented on August 28, 2024

Hi that's true, it's simple enough to be vendored (meaning we copy/paste the current code in our repository)

the pros & cons:

pros:

  • less dependencies
  • users don't need to rely on this dependency too

cons:

  • in case of any changes in python we need to fix it ourselves
  • if some improvements are added we need to add them ourselves.

I have no strong preference 🙄

do we have a major/manior reason to do this move ? is this blocking some users or something ?

from gspread.

alifeee avatar alifeee commented on August 28, 2024

I think this is something that will not change very often. We basically just use it to polyfill old Python versions, and do not use any advanced features of StrEnum

gspread is usable before without installing StrEnum and I think this is nicer.

from gspread.

muddi900 avatar muddi900 commented on August 28, 2024

StrEnum is part of 3.11+.

Wouldn't this need to be conditional then?

from gspread.

alifeee avatar alifeee commented on August 28, 2024

Context:

#1250 (comment)

#1340

I think there are many "solutions" to this issue, and they all depend on what "problem" we are trying to solve.

Personally, I think the dependency is not needed, especially as we have so few dependencies to begin with (apart from the required Google Auth, we have none (or, only StrEnum, which I argue is unneeded))

from gspread.

muddi900 avatar muddi900 commented on August 28, 2024

Yeah I just checked the StrEnum implementation in cpyton, it's not more efficient to begin with.

I can add it, if y'all would like.

from gspread.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.