How to set base path for swagger.json about mmlib.swaggerforocelot HOT 18 CLOSED

I released new version. New version will be availabe in few minutes in https://www.nuget.org/packages/MMLib.SwaggerForOcelot/1.3.0

Thanks a lot

from mmlib.swaggerforocelot.

Hi The problem is here:

If we assign here options.EndPointBasePath in method UseSwaggerForOcelot like this "/swagger/docs"

and we use basePath in AddSwaggerEndPoints from config EndPointBasePath like "/gateway/swagger/docs"

everything works completly fine.

You can accesS both swagger documentation.

Is it possible to add additional endpoint for mapping ?

private static void UseSwaggerForOcelot(IApplicationBuilder app, SwaggerForOcelotUIOptions options)
=> app.Map(options.EndPointBasePath, builder => builder.UseMiddleware(options));

    private static void AddSwaggerEndPoints(SwaggerUIOptions c, IEnumerable<SwaggerEndPointOptions> endPoints, string basePath)
    {
        foreach (var endPoint in endPoints)
        {
            foreach (var config in endPoint.Config)
            {
                c.SwaggerEndpoint($"{basePath}/{config.Version}/{endPoint.KeyToPath}", $"{config.Name} - {config.Version}");
            }     
        }
    }

from mmlib.swaggerforocelot.

Hi,
thank you for reporting the problem and for research.
Can you provide an example of how you would like to use it?

Or ideal make PR if you know how to implement it. (Contribution is open ☺️)

Thanks.

from mmlib.swaggerforocelot.

from mmlib.swaggerforocelot.

Great.

Of course, when you implement it (maybe I'll make some corrections 😉), then I will release new version to nuget.

Thanks a lot.

from mmlib.swaggerforocelot.

from mmlib.swaggerforocelot.

It looks I don't have rights to push my branch

from mmlib.swaggerforocelot.

Yes. You must creat it in your fork. And then creat PR.

from mmlib.swaggerforocelot.

Sorry but I have still problem with ssh i don't have any idea :(

Could I send You solution by email or etc ?

from mmlib.swaggerforocelot.

Hello,
The standard way to contribute to OpenSource on GitHub is as follows:

1. Create a fork to your repository.
2. Implement your changes in the new branch.
3. Push changes to your origin.
4. Create PR.

If you have problem with creating PR from your repo, than send me link to your fork.

from mmlib.swaggerforocelot.

from mmlib.swaggerforocelot.

OK, but it strange.

Can you upload your solution somewhere and send me a link for it?

from mmlib.swaggerforocelot.

http://www.common-soft.pl/MMLib.SwaggerForOcelot.rar

I am fighting for few hours with this ssh, and i do'nt have solution yet:(

maybe quicker be like this.

Please let me know what You think.

from mmlib.swaggerforocelot.

Hi, I created PR #29, where I implement your changes. (I changed it a bit, because of better understanding)

Please check it, if you are ok with these. Next I'll merge these and release new version.

I don't understand why you have a problem with SSH when you push to your repository. Are you sure you are pushing changes to your fork?

from mmlib.swaggerforocelot.

Its look great:)

About SSH i don't have any idea, i need check my whole computer.

from mmlib.swaggerforocelot.

It has been great to work with Ocelot and swagger.
But here is a strange behavior I am getting.
When I use app.UseSwaggerForOcelotUI with opts.SwaggerEndpoint, it duplicates the swagger documentation for each down services.

I can also integrate down services swagger directly by using app.UseSwaggerUI with SwaggerEndpoint. Here I don't need any configuration and no need of app.UseSwaggerForOcelotUI

Can anyone please tell me what is the right way to get the down services documentation?

from mmlib.swaggerforocelot.

Hi @Arslan-Munir,
Sorry, I'm outside of computer (vacation with family). I'll look at it when I get back.

Please, can you create new issue for this?
Thanks.

from mmlib.swaggerforocelot.

Hi @Burgyn
Sure I will create this as a new issue.
Thanks.

from mmlib.swaggerforocelot.