Code Monkey home page Code Monkey logo

Comments (5)

qurben avatar qurben commented on August 25, 2024 1

@dnl-blkv If you provide a description which is not a string or is an empty string the /device-server call will fail. A check for this would be pretty trivial.

from sdk_php.

dnl-blkv avatar dnl-blkv commented on August 25, 2024

@qurben I don't get what this issue is about. Could you please provide some details? Such as: How To Reproduce / What Should Happen / What Happens

from sdk_php.

dnl-blkv avatar dnl-blkv commented on August 25, 2024

Or is it done already? :)

from sdk_php.

qurben avatar qurben commented on August 25, 2024

@dnl-blkv Updated the description

from sdk_php.

dnl-blkv avatar dnl-blkv commented on August 25, 2024

@qurben I would say:

  • Validating IP address is good, since IPv4 / IPv6 are standards
  • Validating API keys is OK since those aren't expected to change match, and if they change it will be an event which won't go unnoticed
  • I would probably NOT validate description because it is not a critical piece of data, and our standard for description may change breaking older versions of SDKs. We do not want this.

from sdk_php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.