FakeNavigationManager registration changed from Singleton to Scoped about bunit HOT 7 CLOSED

That fixes our issue. Thank you for the fast feedback.

from bunit.

The change was related to #1409 as well.

I don't see much of a reason at the moment not to make it Singleton again - given that it has a dependency to TestContext which is somewhat Singleton.
Any arguments speaking against that @egil ?

from bunit.

If there are no reasons to keep it at scoped. But didn't we change it to scoped due to a dotnet 8 change?

from bunit.

as far as I remember we did this as "mitigation" for the endless recursive loop - at least all of our tests are green (including the new NavMan test)

from bunit.

Weren't there someone that raise an issue wanting this to be scoped. My brain is fried, so it could very well be it was a first attempt that was not roled back.

Let's revert and push a preview and see if somebody comes calling.

from bunit.

Well - our code indicates that funny bit:

services.AddSingleton<FakeNavigationManager>();
services.AddScoped<NavigationManager>(s => s.GetRequiredService<FakeNavigationManager>());

So we can safely assume, that it doesn't matter and we can revert back :D

Will make a PR.

from bunit.

@vedion There will be a 1.28.2-preview package on NuGet in a few minutes.
Let us know your feedback

from bunit.