Code Monkey home page Code Monkey logo

Comments (7)

daKmoR avatar daKmoR commented on July 28, 2024 1

awesome 💪

@robrez be prepared 😛

from pdfjs-dist.

robrez avatar robrez commented on July 28, 2024 1

Merged #4 , published @bundled-es-modules/pdfjs-dist#2.0.943-viewer. We've tested this version -- using the new "viewer" addition specifically -- in a polymer build and an ng build with nice results. Thanks @datori

Pending more feedback, we can bump to pdfjs v2.1.266 and publish an rc

from pdfjs-dist.

robrez avatar robrez commented on July 28, 2024

What we have now is too closely focused on just the build directory of the pdfjs-dist repo. Many consumers of pdfjs-dist probably want web/*. I'm not sure how much utility might exist in some of the other dirs (external, image_decoders, lib, etc)

I've just noticed that pdfjs has published another release - v2.1.266 (2 days ago)

from pdfjs-dist.

robrez avatar robrez commented on July 28, 2024

Worth noting, too, that I've been meaning to research this region. I think it makes the es bundle much larger than it really ought to be by bundling what really ought to be an "import"

worker = require('./pdf.worker.js');

from pdfjs-dist.

robrez avatar robrez commented on July 28, 2024

Update:

@datori has been working on resolving all of the concerns above. he has submitted a PR:
#4

I've just left a few review comments -- but feel good about the PR as a whole. Feel free to provide additional review!

from pdfjs-dist.

web-padawan avatar web-padawan commented on July 28, 2024

Thanks! Will take a look soon.

from pdfjs-dist.

robrez avatar robrez commented on July 28, 2024

Closing as resolved, internal testing and feedback has been positive

from pdfjs-dist.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.