Comments (4)
lox
commented on July 28, 2024
Sorry about that! Yup, it looks like we have the shell that executes commands defaulting to bash -c, if you set shell to bash -e -c then you will get the fail on error behaviour.
This should be the default I think. @toolmantim thoughts?
from docker-buildkite-plugin.
toolmantim
commented on July 28, 2024
This is fixed in v1.4.0 (🌽 Chip and Dip)
from docker-buildkite-plugin.
sjtyro
commented on July 28, 2024
Awesome, thanks Tim!
from docker-buildkite-plugin.
toolmantim
commented on July 28, 2024
You're welcome! Thanks for the great error report @sjtyro, and sorry you hit that!
I hesitated to change it earlier in #50, but then forgot to follow it up with another PR to fix it. Your report was the perfect reminder, and you made it clear we didn't need to do a major version bump on the plugin, just a minor because it's basically a bug.
🙏🏼
from docker-buildkite-plugin.
Related Issues (20)
- Building arm compatible containers HOT 1
- Pull request tests are building on the wrong repository HOT 1
- Why doesn't `propagate-environment` include env vars set in hooks? HOT 6
- input from block steps not passed in env HOT 1
- Can't interpolate ENV vars in mount path HOT 3
- Docker on Docker support HOT 1
- Exit codes > 1 are not correctly propagated HOT 2
- Dependency Dashboard
- GPU parameters not passing in Docker Run {--gpus 1} HOT 3
- Allow setting config globally, instead of per step HOT 1
- Limitation with an array of commands at the step level
- Handling of parameters when shell is false HOT 4
- Changing the Docker Version from 20.10.9 to 20.10.22 HOT 1
- `.ssh/known_hosts` mounted in wrong location when both `mount-ssh-agent` and `user` are used HOT 3
- Documentation: expand-volume-vars expansion time HOT 2
- error pulling amazonlinux:latest HOT 6
- How to pass environment variable to command? HOT 2
- Support for other docker commands than docker run HOT 2
- Windows: docker: Error response from daemon: invalid volume specification
- add `expand-workdir-vars` option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-buildkite-plugin.