[🐞] The behaviour of the cache has changed 1.5.0 (cloudflare) about qwik HOT 13 CLOSED

Can you try building with the link I gave you?

from qwik.

Rereading this, it looks like the one I gave you is indeed working and you accidentally gave me the commit after the broken commit as the fixed one.

I will revert the waitUntil patch

from qwik.

@dejurin I'll release 1.5.1 soon. Maybe you can open a case with CloudFlare to have them look at why waitUntil breaks their caching? Point them at #5952

from qwik.

cloudflare/cloudflared#1196

from qwik.

The only commit I can think of that did something is this 1995753 - what seemed like a bugfix in that it waits until the SSR result completed to store the result to cache.

Could that explain what you're seeing? I don't understand what you're suppposed to get in your repro.

from qwik.

Actually you can verify if that's the commit by using the build from the commit before it - https://github.com/BuilderIO/qwik-build/tree/2c7014d476ba9223f1467aabbd8ddd23ff051fbf - see the instructions there.

from qwik.

The only commit I can think of that did something is this 1995753 - what seemed like a bugfix in that it waits until the SSR result completed to store the result to cache.

Could that explain what you're seeing? I don't understand what you're suppposed to get in your repro.

Thank you for response.
It's not clear, to me, the behavior of the cache after the update. Let me explain my observations.

• At each page hard refresh we see 15 seconds delay https://1-4-5.pwa-example-6dn.pages.dev/ (qwik v1.4.5) - the clock on the page is not updated.
• At each hard refresh, the page https://pwa-example-6dn.pages.dev/ (qwik v1.5.0) displays a new time without cache.

from qwik.

Can you try building with the link I gave you?

So, I built.

Work with a 15-seconds delay.
1995753 fix(cloudflare): wait to cache until response complete (#3679) - before

https://ad8f1782.pwa-example-6dn.pages.dev/

    "@builder.io/qwik": "github:BuilderIO/qwik-build#8212a8a75e414cf9ccbc0f4c863a4a4a5580e0d9",
    "@builder.io/qwik-city": "github:BuilderIO/qwik-city-build#12ea064643102110f0a7b674c5c03efaea4080e0",

Works the same as in version 1.5.0
b85761c fix(create-app): tmpdir handling (#5938) - before

https://ada7fe68.pwa-example-6dn.pages.dev/

    "@builder.io/qwik": "github:BuilderIO/qwik-build#1573c1c6e9cfb1b174660a45824d0586ded64627",
    "@builder.io/qwik-city": "github:BuilderIO/qwik-city-build#01ce000902a58a7eaf2503a0164f97992e1cf58c",

from qwik.

Ok so it wasn't that commit then. Could you try building with previous commits after the 1.4.5 commit? You can binary search or just guess which commit might be the culprit based on the contents

from qwik.

If I understand correctly, that's the 1995753 fix(cloudflare): wait to cache until response complete (#3679) reason

from qwik.

Ok so you can confirm that the commit I gave you does not have the problem you're seeing in 1.5.0?

from qwik.

Ok so you can confirm that the commit I gave you does not have the problem you're seeing in 1.5.0?

yep, your commit b85761c fix(create-app): tmpdir handling (#5938) is work well. It does not affect the behavior of the cache.

from qwik.

Wait that doesn't make sense at all, that commit comes after the commit that adds the cloudflare wait. It should fail.

from qwik.