`emit()` arguments about angular-socket-io HOT 4 CLOSED

@jkirkwood maybe submit a PR with this change plus a test case?

Is this possibly because of a "use strict"?

from angular-socket-io.

Ah, that's it. From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/Strict_mode#Making_eval_and_arguments_simpler:

Second, strict mode code doesn't alias properties of arguments objects created within it. In normal code within a function whose first argument is arg, setting arg also sets arguments[0], and vice versa (unless no arguments were provided or arguments[0] is deleted). arguments objects for strict mode functions store the original arguments when the function was invoked. arguments[i] does not track the value of the corresponding named argument, nor does a named argument track the value in the corresponding arguments[i].

When I concat my js files, angular.js is at the top which starts with:

/**
 * @license AngularJS v1.2.16
 * (c) 2010-2014 Google, Inc. http://angularjs.org
 * License: MIT
 */
(function(window, document, undefined) {'use strict';

so 'use strict' is in the function scope, and not applied globally because it is not the first statement.

Should angular-socket-io also be modified to declare 'use strict' on the function scope? Like so?

angular.module('btford.socket-io', []).
  provider('socketFactory', function () {
    'use strict';
    ...

from angular-socket-io.

Yep. would you like to put together a PR?

from angular-socket-io.

Fixed in #55.

from angular-socket-io.