GetBlock() returns *errors.errorString instead of *RPCError about btcrpcclient HOT 5 CLOSED

Thanks for the report. What server are you communicating with? I ask because I just tried this with btcd and it appears to work correctly:

    // Try to get block that doesn't exist.
    hash := &wire.ShaHash{}
    block, err := client.GetBlock(hash)
    if err != nil {
        log.Fatalf("type: %T, error: %[1]v", err)
    }
    log.Print(block.Sha())

2015/07/11 23:19:45 type: *btcjson.RPCError, error: -5: Block not found

from btcrpcclient.

I'm using bitcoin-qt:

hash, err := wire.NewShaHashFromStr(rawTx.BlockHash)
block, err := client.GetBlock(hash)
if err != nil {
  fmt.Println(reflect.TypeOf(err))
}

I'll try to look into it a bit more today.

from btcrpcclient.

Still seeing this issue, connecting locally using bitcoing-qt and also connecting to bitcoin core. Its a bit of a problem for me because it makes error detection harder. Any idea what might be the problem, or is this a core issue?

from btcrpcclient.

@scisci Still a problem? What version of go?

from btcrpcclient.

I was able to reproduce this and will submit a PR that fixes it shortly.

from btcrpcclient.