Client hangs after wallet is shutdown about btcrpcclient HOT 7 CLOSED

After tracing this I've found that rpcclient was trying to auto-reconnect, so I've set DisableAutoReconnect to true and now it raises the error as expected. I'm still finding a hang but it's for Wait on btcwallet to exit after receiving a SIGINT.

I've updated the gist to demonstrate the issue with btcwallet

from btcrpcclient.

If this is hanging before the Wait calls for the btcwallet process, and not after (when you make a final call to GetNewAddress, then wallet isn't shutting down correctly. Can you run wallet with profiling and dump the goroutines?

from btcrpcclient.

Here's the dump of goroutines when it hangs:

https://gist.github.com/tuxcanfly/549ec22a9d4496117028

I can see that when I hit Ctrl+C manually, it shuts down correctly:

23:32:23 2014-07-01 [INF] BTCW: Received SIGINT (Ctrl+C).  Shutting down...
23:32:23 2014-07-01 [WRN] BTCW: Server shutting down
23:32:23 2014-07-01 [WRN] BTCW: Disconnecting chain server client connection
^C23:32:26 2014-07-01 [INF] BTCW: Received SIGINT (Ctrl+C).  Shutting down...
23:32:26 2014-07-01 [WRN] BTCW: Server already shutting down
23:32:26 2014-07-01 [INF] BTCW: Disconnected websocket client 127.0.0.1:41610
23:32:26 2014-07-01 [INF] BTCW: Shutdown complete

from btcrpcclient.

Steps to repro:

Keep rpcclient connection open, I have something like this in a simple test script:

for i := 0; i < 10; i++ {
    time.Sleep(time.Second)
    addr, err := client.GetNewAddress()
    if err != nil {
        log.Printf("Cannot generate new address: %v", err)
    }
    log.Printf("Address: %v", addr)
}

While this is running, I interrupt btcwallet with SIGINT. Both btcwallet as well as rpcclient hang.

Here's the goroutine dump for btcwallet: https://gist.github.com/tuxcanfly/924fc97f4fed16cd383d

from btcrpcclient.

That looks like a btcwallet clean shutdown bug, not the issue I was seeing with the rpcclient hanging. In this case, wallet is waiting for new messages from a websocket client (rpcserver.go:433) instead of erroring and breaking out of the loop (which should shut down the remaining rpcserver goroutines).

from btcrpcclient.

OK, I was guessing this was the same rpcclient issue because once btcwallet hangs, it keeps the client waiting.

I guess this issue should be moved to btcwallet.

from btcrpcclient.

The shutdown hangs in btcrpcclient have been resolved as of commit 656fa86.

from btcrpcclient.