Comments (5)
dennisreimann
commented on August 20, 2024
@Kukks Is there a special reason why we don't have them for ConnectTo and GetDepositAddress? For CancelInvoice we are explicit and passing a CancellationToken.None to the underlying implementations, but for the others we are just omitting the CT, though I think we should pass it.
from btcpayserver.lightning.
Kukks
commented on August 20, 2024
@Kukks Is there a special reason why we don't have them for
ConnectToandGetDepositAddress? ForCancelInvoicewe are explicit and passing aCancellationToken.Noneto the underlying implementations, but for the others we are just omitting the CT, though I think we should pass it.
ack for adding them
from btcpayserver.lightning.
dennisreimann
commented on August 20, 2024
@Kukks I can do that next — what about the CancelInvoice one? Are we omitting it consciously or shall it get added too?
from btcpayserver.lightning.
Kukks
commented on August 20, 2024
Go for it
…On Fri, May 13, 2022, 13:46 d11n ***@***.***> wrote:
@Kukks <https://github.com/Kukks> I can do that next — what about the
CancelInvoice one? Are we omitting it consciously or shall it get added
too?
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN357UVZZHFSVIBCFSU5V3VJY6JNANCNFSM5TUDFTFA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from btcpayserver.lightning.
NicolasDorier
commented on August 20, 2024
Pushed new packages.
from btcpayserver.lightning.
Related Issues (20)
- Parsing with invoices using feature bit above 63 overflows HOT 1
- Implement LNProxy-like privacy
- Incorrect "Closing Channel" balance for LND
- Update Eclair client to resolve occasional test flakiness
- drop the `certfilepath` argument which is definitely wrong and it fails to connect HOT 4
- Amount is wrong for `p` amount units HOT 8
- Eclair does not work with Bitcoin Core 0.19.0.1 HOT 4
- Fix LND 0.9 compatibility HOT 2
- Add support for Clightning-rest
- Allow setting a user for Eclair
- Allow insecure connections to Charge (skip https validation) HOT 3
- LND swagger client fails to parse response for CloseChannelAsync HOT 1
- Full Electrum Wallet integration (Bitcoin and Lightning)
- LND Swagger client cannot establish a peer connection and always reports 'ConnectionResult.Ok' HOT 8
- @NicolasDorier I agree this should be default if the feedback we get is good, good idea. HOT 1
- Add missing parameters from the current lnd lightning swagger definition
- Change ConnectionResult enum
- Add GetBalance
- Onchain balance for LND implementations with incorrect format
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from btcpayserver.lightning.