RSS Posts Links should be fully qualified. about golangflow HOT 8 CLOSED

@darron Thanks for willing to contribute, Which troubles are you having with Buffalo?

from golangflow.

@darron https://github.com/bscott/golangflow/blob/master/actions/home.go#L47 shows usage of the app host. You can also get the host from the request.

from golangflow.

In theory appending the host here https://github.com/bscott/golangflow/blob/master/actions/home.go#L63 should it.

from golangflow.

from golangflow.

@darron I'm curious as to how you're trying to print stuff out.

This worked for me:

	c.Logger().Debugf("host: %s", App().Host)

time="2017-07-11T09:48:06-04:00" level=debug msg="host: http://127.0.0.1:3000" method=GET params="{}" path="/rss" request_id=98e632ee05-c05154116e 

Also fmt.Printf works for me too.

How are you trying to log stuff?

Also, I updated the code with the following:

Link:  &feeds.Link{Href: fmt.Sprintf("%s/posts/%s", App().Host, p.ID)},

And it worked no problem.

    <item>
      <title>Post 2</title>
      <link>http://127.0.0.1:3000/posts/c68c8f7c-fe30-48a1-a331-f4f7b33d7d8a</link>
      <description>content for 2</description>
      <author>DB Seed</author>
      <pubDate>Tue, 11 Jul 2017 09:50:47 +0000</pubDate>
    </item>

How are you trying to build the link?

from golangflow.

I was doing it pretty much the exact same way.

I thought that maybe there was some old/duplicate versions of software around - so I blew away all my old buffalo binaries, pulled this repo again and started from scratch:

export GOPATH="/Users/dfroese/go"
cd ~/go/src/github.com/bscott
[email protected]:bscott/golangflow.git
cd golangflow
go get -u -v github.com/gobuffalo/buffalo/buffalo
dep ensure
npm install
buffalo dev

This is the only change:

Link:        &feeds.Link{Href: fmt.Sprintf("%s/posts/%s", App().Host, p.ID)},

Now it totally works like it should - no more missing / in the <link>.

Thanks for the tip about c.Logger() - wasn't aware that was available.

I am not sure what happened there - but now it all seems to work.

Sorry for the false alarm / bug report - appreciate the help sorting it out.

from golangflow.

No worries. Not sure what the mismatch was, but glad you got it working. :)

from golangflow.

Fixed and merged. Thanks @darron

from golangflow.