Code Monkey home page Code Monkey logo

Comments (7)

brutella avatar brutella commented on September 26, 2024

Go ahead, looking forward to your pr 🙂

from hc.

tjbx avatar tjbx commented on September 26, 2024

I've no experience with the whole git thing. Here is a diff for the above mentioned GetFirstLocalIPAddress func.

mdns.hostname.diff.txt

Since the hap.Config solution is more involved, it will take a while longer.

from hc.

brutella avatar brutella commented on September 26, 2024

Please check if commit 82a77ed resolves this issue

from hc.

tjbx avatar tjbx commented on September 26, 2024

Seems to work for me though it might be nicer to be able to specify the ip address as a string in the config (like all the other config vars) and then convert it in code with net.ParseIP. The fix for the "Invalid characteristic found when using HomeKit and AppleTV for remote access #43" also seems to work great. Thanks much.

from hc.

tjbx avatar tjbx commented on September 26, 2024

Sorry for the slow reply - sometimes I get updates from github via email and other times I only see them when I visit this webpage. Anyhow, I tried it and the IP as string seems to work as expected. One last(?) request would be to somewhere still have the

log.Println("[INFO] Accessory IP is", ip)

that used to be in "func (s *MDNSService) Publish() error" of hap/mdns.go

just as a sanity check to make sure the ip address you specify is the one being used. Not completely necessary but could be helpful in debugging.

from hc.

tjbx avatar tjbx commented on September 26, 2024

Works as desired. Thanks.

from hc.

brutella avatar brutella commented on September 26, 2024

Fixed with d8c223d

from hc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.