Comments (5)
We learned a lot from that internal conversation! I'll link to our findings and subsequent code changes, as they may be useful to other users of this package:
- https://github.com/edx/edx-platform/blob/master/docs/decisions/0009_simplify_ratelimiting.rst
- openedx/edx-platform#26487
Basically, we found out that our login rate limiting in that service was a confusing pile of overlapping implementations. At least for our use case, django-ratelimit covers what we need (and was already in use for other URLs), so I'm afraid we'll be dropping our fork of this package. The notes above may help serve as a migration path for others.
from django-ratelimit-backend.
@jmbowman thanks, indeed I'm happy to transfer ownership to a maintained fork. Is the EDX fork the one you're referring to?
from django-ratelimit-backend.
Yes; I just kicked off an internal conversation about potentially adopting this, hoping to have a consensus on it by next week. That'll also give some time for anybody currently using another fork to chime in with any suggestions or questions.
from django-ratelimit-backend.
Thanks!
from django-ratelimit-backend.
Thanks @jmbowman, interesting read
from django-ratelimit-backend.
Related Issues (15)
- Remove admin.autodiscover() for URLconf example
- In Usage, document authenticate(..., request=request) HOT 1
- Installing django-ratelimit-backend includes the tests HOT 1
- Enable squash merging
- Does not work with OAuth 2 bearer tokens
- How do you make it work with django reCAPTCHA?
- How to set the username_key when using django-allauth that accepts either username or email?
- Can this be used to do soft-lockouts, too?
- Not compatible with django-cms 2.3.1? HOT 1
- Don't raise UserWarning 'No request passed to the backend' during tests HOT 2
- following example for custom backend: no 'username' in request.POST
- app hides admins of third party apps HOT 4
- Improve explanation of replacing admin with rate-limited admin HOT 1
- Bump version and release on PyPI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-ratelimit-backend.