Code Monkey home page Code Monkey logo

Comments (2)

jsilvestre avatar jsilvestre commented on August 18, 2024

I have the same result when running brunch build with

module.exports.config =
...
optimize: true
...

I changed the plugin's code to make it work (it's kinda dirty though):

...
 try {
    optimized = uglify.minify(data, this.options);
  } catch (_error) {
    error = 'JS minification failed on ' + path + ': ' + _error;
  } finally {
    getMap = function(json) {
      this.json = json;
      this.toJSON = function() {
        return this.json;
      }
    };
    if (error) return callback(error);
    var result = optimized && this.options.sourceMaps ? {
      data: optimized.code,
      // map: optimized.map -> before
      map: getMap(optimized.map) // -> now
    } : {data: optimized.code};
    callback(null, result);
  }
};
...

The error no longer appears but the source maps aren't correct neither, but that's another issue I believe. I hope this piece of code can help you in some way.

Edit: this can help you but you must not c/c the code as-is.
As far as I understand, we pass Brunch a string where it expects something else with a toJSON() methd. Not sure who is right though, someone will help us here hopefully :)

from terser-brunch.

shvaikalesh avatar shvaikalesh commented on August 18, 2024

Closed for inactivity. Please reopen if the issue persists with latest Brunch & plugins.

from terser-brunch.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.