v 4.1 not working in a TypeScript project about sleep-promise HOT 7 CLOSED

All works like a charm now! 😍 Many thanks for your time @brummelte!!!

from sleep-promise.

Tools like webpack support the "module" notation in package.json. So using TypeScript with webpack might work and use the esm-file. I've added type definitions for the esm-file. But I'm not sure if they will be loaded correctly. It seems like you can only define one entry file for types.

I can't seem to get TypeScript (without webpack) to work with the module syntax anyway. The following doesn't seem to work:

import sleep from 'sleep-promise/build/esm';

And I don't want to add a default export to the common js bundle. So I've reverted the types.

You now will have to import it as import * as sleep … with TypeScript. Adding --allowSyntheticDefaultImport might also work to get TypeScript to accept a default export.

I'm closing this for now, because this has cost me too much time already.

If anybody finds a way of adding default import compatibility for TypeScript without changing the commonJS file, I'm happy to take a look again.

from sleep-promise.

Thank you @brummelte! One final minor bit: could you please add !types/* to .npmignore? Otherwise, type definition files are not published and we're going back to #6 (comment) 😅

from sleep-promise.

Sorry :-)

!types/* not being added is correct. The path in package.json was wrong. Fixed now.

from sleep-promise.

You now will have to import it as import * as sleep … with TypeScript.

Hi @brummelte, shouldn't the README be updated accordingly

from sleep-promise.

@abel-mak it's only for TypeScript. If you can find a way to make TypeScript work with the default import, I'm happy to change it.

from sleep-promise.

@brummelte i see, thanks for responding!

from sleep-promise.