Code Monkey home page Code Monkey logo

Comments (5)

SHuang-Broad avatar SHuang-Broad commented on July 23, 2024

For WDL

  • should we use tabs vs spaces
  • if using spaces, should we use 2 or 4

from long-read-pipelines.

kvg avatar kvg commented on July 23, 2024

We should come up with standards for Docker images as well. For example, make sure installed tools reside on the PATH. I just tripped myself up with two docker images of mine that had the same tool installed, but in different locations, and that seems silly.

from long-read-pipelines.

SHuang-Broad avatar SHuang-Broad commented on July 23, 2024

Agree.
Regarding dockers, I actually prefer not aggregating tools into a single docker, unless it is something very very basic like samtools, gsutils, etc.
And when the pipeline gets complicated, the docker DAG gets complicated as well, but I have a way to manage that to balance out build time, docker size (not that big of a deal for long reads yet because we won't have 10k samples), and complexity.

from long-read-pipelines.

kvg avatar kvg commented on July 23, 2024

I think we've more or less converged on decent rules for our WDL files and Docker images.

WDL:

  • spaces, not tabs
  • tab = 4 spaces

Docker images:

  • prefer many small images over monolithic images
  • prefer standalone images over bunch of images that depend on each other and need to be built in a specific order to function properly

from long-read-pipelines.

SHuang-Broad avatar SHuang-Broad commented on July 23, 2024

I'd vote for codifying these in a document.
I'll draft another document for this.

from long-read-pipelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.