Code Monkey home page Code Monkey logo

Comments (3)

brianmario avatar brianmario commented on June 1, 2024

Someone already opened a ticket about this (see #44) - I'll think about what I want to do more, but you can get the gist of my stance on a "fix" for this in #44.

Basically I'd rather have you (the caller) pass in a string explicitly instead of doing magical casting down inside mysql2. This could quickly become a slippery slope IMO. If we're going to automatically convert the password to a string, why not do the same for username, socket, host, etc...

I may still pull your patch in, but I want to think about it more. Closing the ticket for now.

from mysql2.

krekoten avatar krekoten commented on June 1, 2024

Sure, thx. I tried to search for such ticket, but didn't find it. Well, I was thinking too, that maybe this conversion should be done in higher level, on caller side...
Anyway, thx for response.

from mysql2.

brianmario avatar brianmario commented on June 1, 2024

No problem dude, appreciate the work you put in for the patch :)

from mysql2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.