Comments (3)
Someone already opened a ticket about this (see #44) - I'll think about what I want to do more, but you can get the gist of my stance on a "fix" for this in #44.
Basically I'd rather have you (the caller) pass in a string explicitly instead of doing magical casting down inside mysql2. This could quickly become a slippery slope IMO. If we're going to automatically convert the password to a string, why not do the same for username, socket, host, etc...
I may still pull your patch in, but I want to think about it more. Closing the ticket for now.
from mysql2.
Sure, thx. I tried to search for such ticket, but didn't find it. Well, I was thinking too, that maybe this conversion should be done in higher level, on caller side...
Anyway, thx for response.
from mysql2.
No problem dude, appreciate the work you put in for the patch :)
from mysql2.
Related Issues (20)
- Ruby 2.7.0 Mysql2 query doesn't sum decimal(8,2) values correctly HOT 2
- This gem was compiled for 10.5.19-MariaDB but the client library is 3.1.20. HOT 8
- cast: false doesn't work for prepared statements
- Mysql2::Error: Unsupported charset: '"utf8mb3"'
- ld: library not found for -lzlib HOT 7
- Disregard
- Segmentation faults randomly when running test on CircleCI (Rails, Minitest)
- mysql2 v0.5.5 with brew ruby v3.2.2_1 lead dyld[13277]: missing symbol called trap HOT 3
- Ruby 2.3.4 & mysql2-0.5.3 [BUG] Segmentation fault HOT 1
- Mysql2::Client session_track specs fail against MySQL 8.0.33 HOT 1
- MySQL 8.0.34 and 8.1.0 deprecates `MYSQL_OPT_RECONNECT` HOT 10
- Unable to install 0.5.5 on Macbook M2 HOT 3
- All gem DL locations wrong? Or am I doing something terribly wrong? HOT 2
- Does a mysql2 to MySQL version compatibility list exist? HOT 3
- LoadError: libruby.so.2.7: cannot open shared object file: No such file or directory HOT 1
- Samplog_Init HOT 1
- MySQL 8.1 and mysql2 gem version 0.5.5 - ArgumentError: negative string size (or size too big) HOT 6
- Error installing mysql2 on Mac M1 pro (ventura) HOT 4
- "pluggable authentication is not available" for recent client library HOT 1
- UUID support? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mysql2.