Integrate Jasmine 2.0 and RequireJS in a better way than currently MacysUI does about marionette-ref-impl HOT 9 CLOSED

0f08451

from marionette-ref-impl.

I don't think we need to do the setTimout() in the before each, jasmine 1.x has a way to do this that we are not using. It uses the waits(). So if you are seeing setTimeout then the test is not being done correctly.

from marionette-ref-impl.

with Jasmine 2.0 there is an even better approach than using waits(), they have a done callback: this new approach is described at Upgrading Jasmine - Asynchronous Specs

However my approach here is to require the module outside of the describe and then we would need no async feature at all :)

Like this: https://github.com/brendajin/marionette-ref-impl/blob/0f08451156944e1eec5dfd3cb835011407b37fb8/test/base/application.spec.js

from marionette-ref-impl.

Same thing, different name. Grunt actually does async with the done() and it can be problematic.

from marionette-ref-impl.

The advantage of using done is that if we have more than 1 callback they don't have to be nested, but they would be flattened instead by doing one block for each precondition. In order to ease that I have authored a very simple preCondition instruction for Jasmine 2.0's way of async testing: https://github.com/tiagorg/jasmine-precondition and also on NPM.

However for this case here, if we are able to use requireJS outside of the test we won't need to go down on this path. That would be cleaner I suppose

from marionette-ref-impl.

Are you using jasmine 2.0 or 2.1?

from marionette-ref-impl.

2.1, just noticed the title saying 2.0. We are using the latest to see how would it be like.

from marionette-ref-impl.

unified karma's and main's require-config here: f27b750

from marionette-ref-impl.

Improving the specs for application: a411bec

from marionette-ref-impl.