Code Monkey home page Code Monkey logo

Comments (5)

bridiver avatar bridiver commented on July 28, 2024

which brave electron version? It may be this
082272d

from muon.

bridiver avatar bridiver commented on July 28, 2024

it broke after electron/electron@e5daf63
and was fixed in the commit above

from muon.

Mossop avatar Mossop commented on July 28, 2024

I just retested with current master, v1.4.8 and still see the issue. I've been trying to bisect but it looks like you rebase for each new Electron version which makes bisecting more difficult.

from muon.

bridiver avatar bridiver commented on July 28, 2024

Interesting. We also register custom protocol handlers, but we're using navigator.registerProtocolHandler so I guess it's possible that the electron api still has a problem with our changes

from muon.

bridiver avatar bridiver commented on July 28, 2024

on the rebase issue, we have been the only people using our fork so far afaik and rebasing made things easier for us, but we're trying to move our changes from atom -> brave and upstream some changes to make it easier to extend

from muon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.