Comments (5)
which brave electron version? It may be this
082272d
from muon.
it broke after electron/electron@e5daf63
and was fixed in the commit above
from muon.
I just retested with current master, v1.4.8 and still see the issue. I've been trying to bisect but it looks like you rebase for each new Electron version which makes bisecting more difficult.
from muon.
Interesting. We also register custom protocol handlers, but we're using navigator.registerProtocolHandler
so I guess it's possible that the electron api still has a problem with our changes
from muon.
on the rebase issue, we have been the only people using our fork so far afaik and rebasing made things easier for us, but we're trying to move our changes from atom -> brave and upstream some changes to make it easier to extend
from muon.
Related Issues (20)
- C66: Crash on tab detaching on Mac/Linux HOT 2
- enableDeviceEmulation
- Unknown Extension API - i18n.getAcceptLanguages
- Injecting JS and CSS into <webview> tag. HOT 1
- Alert, prompt doesnt open. HOT 2
- C67: crash in resource_coordinator::TabManager::SetTabAutoDiscardableState HOT 1
- User Tor toggle restarts Tor process HOT 2
- C67: spellcheck not working on Linux/Win HOT 6
- C67: use system python for update-external-binaries.py HOT 2
- C67: make TabHelper::Discard() to properly discard tabs
- user prefs not applied to 'persist:tor' session HOT 1
- Private tabs with Tor enabled write cookies to disk HOT 1
- Retire Tor circuit isolation keys HOT 1
- C68: crash switching tabs after closing the active one HOT 3
- C68: Crash on popping up notifications on Linux
- Quality readable documentation
- Question: ungoogled-chromium instead of vanilla chromium? HOT 1
- An UAF bug exists in muon HOT 2
- Webview mutes parent.postMessage() HOT 1
- The release naming is confusing.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muon.