Clearing directions, NPE in DirectionsRenderer about gwt-maps-v3-api HOT 11 CLOSED

Hmmm, I think this has occurred before in one of the classes and I added a clear b/c the type null didn't pass correctly.

from gwt-maps-v3-api.

Working up the fix

from gwt-maps-v3-api.

I have a branch with the fix, but I'm going to look for any of the others.

from gwt-maps-v3-api.

Ah I remember where I did that, it was in Marker. If the fix I'm adding we can put something like this in place.

  /**
   * close the marker 
   */
  public final native void close() /*-{
    this.setMap();
  }-*/;

from gwt-maps-v3-api.

I pulled the fix #32

from gwt-maps-v3-api.

Merged with master. Waiting for CI to build and deploy. I'm going to close the issue, and if for some reason it still exists, please report it. Thanks for your help.

from gwt-maps-v3-api.

I see you ameliorated this with my workaround in each JSO.

    public final void setMap(MapWidget mapWidget) {
        if (mapWidget == null) {
            setMapImpl(null);
        } else {
            setMapImpl(mapWidget.getJso());
        }
    }

Of course now boilerplate code is repeated, but these are JSO's, so having a simple HasMap interface and AbstractMapLayer is a no go.

However there was an archetype example (response 13) on the GWT Groups Forum today that might serve as a workaround to prevent this common problem from occurring again.

This would mean that layers could be treated with interfaces... like in Java! Noticed this annoyance last week when I could not just have a MapLayer[] to hold the currently displayed layers.

from gwt-maps-v3-api.

We could put this in a super class and inherit it into the sub classes that use the setMap. I've been doing that with some couchdb jso stuff.

from gwt-maps-v3-api.

By the way, I'm not sure this is working. B/c null isn't getting translated correctly when used.

I think will have to chage it to setMap() with no arguments in the jsni.

   public final void setMap(MapWidget mapWidget) {
        if (mapWidget == null) {
            setMapImpl(null);
        } else {
            setMapImpl(mapWidget.getJso());
        }
    }

from gwt-maps-v3-api.

Odd, I had an example in the showcase (local, not committed) where for one of the custom layers I toggled it from setMap(map) and setMap(null) on button click. This made the layer appear and disappear over and over as expected.

Can you detail how I can reproduce that the failure to set null you're experiencing?

from gwt-maps-v3-api.

I think thats happened to me too, but I've had it happen twice and was thinking the same thing. First I think it happened in the Marker. Then recently in another class but I can't recall at the moment.

from gwt-maps-v3-api.