HouseCleaning: MapEvent type declarations about gwt-maps-v3-api HOT 8 CLOSED

Sounds good. :)

from gwt-maps-v3-api.

Have you done anything with this?

from gwt-maps-v3-api.

Hmmm, I'm looking at the handlers, and I remember trying to paramertize the MapEvent before but seemed a static type was slowing me down. I haven't found it all yet. While I'm looking I see line width of 80, do you mind if I reset the stuff to 120?

from gwt-maps-v3-api.

Wow, flash backs trying to extract this. Ugh b/c the TYPE is static it causes some inheritance, then GwtEvent MapEvent wants both the event type and handler creates some fun. :)

from gwt-maps-v3-api.

How far down the rabbit hole would you like to go on this? I think b/c of the way GwtEvent I was a little constrained and I also generified it a bit. Since this works, I'm not sure its worth it. Thoughts?

Although adding a wild card gets rid of the eclipse warning.

 public static <E extends MapEvent<?, E>> HandlerRegistration addHandler(...

from gwt-maps-v3-api.

Frankly it is not a big deal. Thanks for looking into it. I just try not to have any warnings in Eclipse and this is one of the few we have left. Frankly, given the limitations of the GWT JSO design and the Maps API, I concede that it is permissible to just suppress this warning, given that we've both investigated and vetted it.

from gwt-maps-v3-api.

Sounds good. :)

from gwt-maps-v3-api.

I'm going to close my branch pull request on this issue for now. And leave as is. :)

from gwt-maps-v3-api.