Only supports a single Youtube Embed per Angular App. about angular-youtube-embed HOT 4 CLOSED

:( this is true.

do you have any suggestions of how this should look? since there's only a single $youtube service for your entire app, instead of a single $youtube.player reference, it could be like $youtube.getPlayer(id), where id is the DOM id. that way, you can control multiple players.

for events, listeners could be passed something telling them the DOM id of the player, so you can distinguish like which one just paused or whatever it may be.

let me know if you've got advice.

from angular-youtube-embed.

I hacked together a messy solution to make it work for my basic use case, but reading your comment I realized theres probably issues related to the onPlayerStateChange event.

I'm just getting familiar with Angular directives so this probably isn't the ideal implementation but what I did was take everything that was in the service and move it into the link function of the directive. That way each instance of the directive had it's own youtube object to control. To make stuff work I also had to change $window.onYouTubeIframeAPIReady to use a global flag rather than a per instance boolean ready and look for that flag in stopWatchingReady.

I hope this helps! If I was more comfortable working with directives I'd fork and fix it for you, but I don't want to muck things up. :)

from angular-youtube-embed.

I'd have to dig closer into the code, but it by far makes the most sense to me to pass the player in from the events:

$scope.$on('youtube.player.ready', function (player) {
  player.playVideo();
});

and/or you could expose the player to the directive:

<youtube-video id="best-vid" video-url="theBestVideo" player="bestVideoPlayer"></youtube-video>

// $scope.bestVideoPlayer may not be available right away. This is not something that
// should be done in a controller callback, but maybe in an ng-click, etc.
$scope.playVideo = function () {
  if ($scope.bestVideoPlayer) 
    $scope.bestVideoPlayer.playVideo();
};

I feel like you shouldn't have to expose the $youtube service at all.

from angular-youtube-embed.

fixed with b0c0083

from angular-youtube-embed.