Cyrillics issue about router HOT 10 CLOSED

It should be more than that IMHO. Anything that is not a control character should be usable maybe?

from router.

I see that Laravel uses '/\{(.*?)\}/' as the pattern to extract parameters.

I'll gladly accept a PR containing the change (+ accompanying tests) :-)

from router.

I propose to change the line 341-344

$route['pattern'] = preg_replace('/{([A-Za-z]*?)}/', '(\w+)', $route['pattern']);

if (preg_match_all('#^'.$route['pattern'].'$#', $uri, $matches, PREG_OFFSET_CAPTURE)) {

to

$route['pattern'] = preg_replace('/(?![\]p){([A-Za-z]*?)}/', '(\w+)', $route['pattern']);

if (preg_match_all('#^'.$route['pattern'].'$#u', $uri, $matches, PREG_OFFSET_CAPTURE)) {

So that the router allow all unicode characters character class \p{L} according to https://stackoverflow.com/a/38938931

from router.

Apparently $_SERVER["REQUEST_URI"] encodes non-latin and symbols to RFC-3986 and needs to be decoded before the route matching.

from router.

I've just pushed some things to master. Looking forward to your feedback.

The problem here was twofold:

1. Support for Cyrillic/astral/etc. Symbols in route pattern values (e.g. make it so that /hello/💩 matches the route pattern /hello/{name})
2. Support for Cyrillic/astral/etc. Symbols in route placeholder names (e.g. make it so that /hello/bramus matches the route pattern /hello/{име})

I've done two separate commits to tackle this:

1. Support for Cyrillic/astral/etc. Symbols in route pattern values: 0f4733d
2. Support for Cyrillic/astral/etc. Symbols in route placeholder names: ae0db20

Feel free to test this from dev-master (Circle CI says all is fine). If well received I'll tag it as a new release.

from router.

I might have misunderstood this issue. I thought it was about supporting unicode characters on the route itself.

My bad.

from router.

@fscchan Yeah, that was my first impression too. Took me a while to notice that the original poster was adjusting the regex part for the placeholders (e.g. {var} in a route pattern).

While I was at it, I thought I'd just fix both cases ;)

from router.

FYI: Version 1.4 got tagged and released.

from router.

Yes! That worked.
Just one more thing: somewhere in getCurrentUri function the text should be urldecode-ed

from router.

Will take a look into it.

from router.