Regexp to match the whole route not working as expected about router HOT 4 CLOSED

Hi Johan,

Thanks for pointing this out. The regex worked just fine, it was the post-processing (extraction of the callback parameters) that was messing things up. The fix has already been pushed; also included your test in the test suite :)

Regards,
Bram.

from router.

(The fix initially pushed introduced another bug, fixed it for good with 2d8107f

from router.

Ok, thanks for the quick-fix...
I will check that later :)

from router.

Hi,
I'm back I still have a problem with some matching...

If I want to match all routes with pagination I'm using the following rule : "/(*.)/page([0-9]+)"

But it's not working as expected :

• "/my-url/page3" matches returns ["my-url", 3]
• "/my-url/somewhere/page4 returns ["my-url", 4]

Here is a test class that fail :

public function testDynamicRouteValidOrNot() {

  // Create Router
  $router = new \Bramus\Router\Router();
  $router->get('/(.*)/page([0-9]+)', function($place, $page) {
      echo 'Hello ' . $place . ' page : ' . $page;
      });

  // Test the /hello/bramus/page3 route
  ob_start();
  $_SERVER['REQUEST_URI'] = '/hello/bramus/page3';
  $router->run();
  $this->assertEquals('Hello hello/bramus page : 3', ob_get_contents());

  // Cleanup
  ob_end_clean();
}

It returns ["hello", 4].

from router.