Code Monkey home page Code Monkey logo

Comments (12)

Jeel-Shah avatar Jeel-Shah commented on July 20, 2024 3

Hi everyone, Happy to take this on. Will setup Braid over the weekend and take a crack at it.

from braid.

rafd avatar rafd commented on July 20, 2024 2
  • I think changing from "06-06-2020" to "Yesterday" is fine (probably good to have the full date in the elements title so it shows on hover); we already do something similar for the message times so you can reuse or modify the code if relevant.
  • I think there may be value for adding something extra when there is a long delay between messages (ie. having both "2 days later..." and "yesterday", where the "2 days later" would only show for delays greater than, say, 2 days)

from braid.

jamesnvc avatar jamesnvc commented on July 20, 2024

I think this is obviated by #172

from braid.

rafd avatar rafd commented on July 20, 2024

Still think this is relevant... The date divider doesn't make it immediately obvious that day.... 13 days later, someone necroed a thread.

from braid.

rafd avatar rafd commented on July 20, 2024

braid-timecard-mockup

from braid.

rafd avatar rafd commented on July 20, 2024

The code would likely be added around here: https://github.com/braidchat/braid/blob/master/src/braid/core/client/ui/views/thread.cljs#L260

from braid.

rafd avatar rafd commented on July 20, 2024

Part of me is considering whether or not these should have a little whimsy, and be done in the style of SpongeBob time-cards :P https://spongebob.fandom.com/wiki/List_of_time_cards

from braid.

PiotrKurnik avatar PiotrKurnik commented on July 20, 2024

I think I will give it a go in my spare time.

from braid.

rafd avatar rafd commented on July 20, 2024

Hey @PiotrKurnik , jeelshah on Braid was interested on working on this change. I'm going to ping him via email and see if he still wants to do it, but if not, it's yours.

from braid.

PiotrKurnik avatar PiotrKurnik commented on July 20, 2024

Sure, I was just browsing this issue recently ;-)

from braid.

Jeel-Shah avatar Jeel-Shah commented on July 20, 2024

So, a couple questions and clarifications about the feature. As I understand it, the feature is to:

display a human friendly time placeholder for long gaps between messages.

  1. Should we display placeholders between gaps of messages or the last two messages?
  2. Should replace the yyyy-MM-dd in the dividers to a [Name of day], [Name of month] dd format?

Research

After researching the topic a little, I've found that Slack, WhatsApp and Facebook Messenger either show no placeholders as is the case for WhatsApp / Messenger or in the case of Slack, show only a placeholder between the last two messages. For instance, it will show that "time" difference between the last message and the second last message is "yesterday" otherwise, it will simply show the time stamp.

Thoughts

I think design wise, it's probably better to show only the time difference between the last two messages OR if we want to always show a placeholder then to show it for longer periods at a lower bound of 2/3 days and for time periods less than the lower bound, we show the divider.

My inclination is towards the last two messages. Suppose, we have an active thread where people post every 3 / 4 days then each message will be preceded by "3 days later", "4 days later" etc. and this will clutter the UI and I think, make for an uneasy UX. Also, we would have to find a way to display the date of the messages as well.

Related

On a related note, it would be nice to replace the divider yyyy-MM-dd with a [Name of day], [Name of month] dd and if the year of the message is not the current year then [Name of day], [Name of month] dd [year]. This will help with the UX of looking at longer time periods because it's much easier to work with June 6th than 06-06-2020.

"Demos"

Option 1

Option 2

from braid.

Jeel-Shah avatar Jeel-Shah commented on July 20, 2024

Ok, great! I'll implement the "X days later" along with "Yesterday". Sorry, just to clarify one thing about "full date in the elements title ..." So, we're going to have "X days later" or "Yesterday" and then on hover we show the date of the message -- right?

from braid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.