Code Monkey home page Code Monkey logo

Comments (5)

jinpark avatar jinpark commented on July 20, 2024

I can totally take this btw, just wanted to make sure that you're ok with it :)

from django-s3direct.

bradleyg avatar bradleyg commented on July 20, 2024

Sounds good, I've been wondering if there is a clean way to do it without breaking API... but I don't think there is.

from django-s3direct.

jinpark avatar jinpark commented on July 20, 2024

Probably a good way is to create a new version and notify that it breaks backwards compatibility.

from django-s3direct.

bradleyg avatar bradleyg commented on July 20, 2024

ok, sounds like a fair compromise.

from django-s3direct.

ivanvenosdel avatar ivanvenosdel commented on July 20, 2024

Just saw this. Excellent idea. I think a way this can be done in a backwards compatible manner is to do some duck-typing to determine if the old version is in use and then internally convert the current style into the same style of dict as the forward version. Those using the old style will be given a deprecation warning and, after the PyPI release, the docs would be updated to show the new style. Eventually, at some TBD date support for the old version could be dropped.

If someone doesn't beat me to it, I will make a note to see if I can fit this in with #62. I think the feature needed for #62 can require the new version as a way to encourage adoption. The dict I spoke of in that ticket can be an 'extra_options' key in the new style.

from django-s3direct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.