Code Monkey home page Code Monkey logo

Comments (3)

BradLarson avatar BradLarson commented on May 28, 2024

I'm not sure that I follow you.

If I understand you, you are capturing from the camera while the device is in the portrait orientation. Your interface, however, is in landscape. You don't have a rotation filter being applied, because that's only necessary if your interface is in portrait orientation.

When you capture from the camera, you override the default orientation of the device and specify landscape manually so that the resulting UIImage has the correct orientation set for it. When you do this, the image you get has the width and height dimensions swapped.

Am I interpreting that correctly? If so, I'd need to look into how that could be happening, because the only time I'm aware of the image dimensions being swapped is if you have a rotation filter after the camera, and that feeds into your filter chain.

from gpuimage.

 avatar commented on May 28, 2024

The image is being captured in portrait view with no rotation filter applied. I manually passed the image orientation as the orientation to process it as. I had to do this to keep it from automatically rotating the image. As stated on http://stackoverflow.com/questions/905217/detecting-iphone-camera-orientation and on http://dev.totodotnet.net/post/20290435414/which-direction-is-uiimageorientationup the camera is actually landscape native so landscape is up and down and portrait is left and right. The code in GPUImage will actually set the orientation incorrectly making portrait pictures turn landscape. If you pass the image's orientation with [image imageOrientation] to imageFromCurrentlyProcessedOutputWithOrientation function it will fix this issue.

But, that is not the new issue. The new issue is it is still swapping the widths and heights. I noticed this after setting the orientation properly. So, I then put in some debug statements to print out the width and height before and after finalImage is set (in GPUImageFilter.m under the function imageFromCurrentlyProcessedOutputWithOrientation). Before it is set the width and height of cgImageFromBytes is correct, however finalImage (which places cgImageFromBytes into a UIImage) has the width and height swapped making the image in landscape view even though the orientation of the image is properly set to be in portrait view.

I am assuming that maybe after reading your response that even though the rotation filter is not applied the orientation is essentially doing the same thing as the rotation filter.

from gpuimage.

BradLarson avatar BradLarson commented on May 28, 2024

Try this now, because I've completely rewritten the rotation interface to remove the rotation filter and have this be handled by the filters internally.

from gpuimage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.