assert in GemRB::Window::DispatchMouseMotion about gemrb HOT 9 CLOSED

this assert probably doesnt need to exist (as you noted we dont actually use the states here). the idea here is that if we have a drag then some button ought to be down.

I'm not sure why this is happening tho. the trackingView variable ought to get set to NULL when the mouse is released. It's almost like the events arrive out of order.

from gemrb.

I checked and managed to crash it while the button was still pressed. But yeah, it could be from the previous pair/attempt.
Didn't manage to reproduce with portrait dragging.

from gemrb.

too early to say for sure, but we should examine the possibility of the EventManager::mouseButtonFlags variable getting out of sync with SDL.

from gemrb.

It's also not universally true that a button must be down during drag — inventory item dragging.

from gemrb.

"Inventory dragging" isn't the same. Window is dealing with true mouse dragging (button is down followed by a movement) not a conceptual drag.

I have this mostly fixed. Looks like there is still an issue when distributing events between 2 windows. Example: mouse down inside one window then drag and release in another. the origin window will continue to think the mouse is down.

the solution is to add an implementation of Window::OnMouseLeave and probably move some of the trackingView code from Window::DispatchMouseMotion there

from gemrb.

this is hopefully unrelated, but is seems that the selection rect on GameControl no longer gets drawn.

I checked out prior to my changes and its still broken, so not sure what happened with it

from gemrb.

suspect #50.

from gemrb.

indeed. must have forgotten about that (been gone for a while if you hadn't noticed ha ha)

can we close this then?

from gemrb.

Sure. Please clear out your stashes before working on something new, so it'll be easier to work together.

from gemrb.