Comments (9)
this assert probably doesnt need to exist (as you noted we dont actually use the states here). the idea here is that if we have a drag then some button ought to be down.
I'm not sure why this is happening tho. the trackingView
variable ought to get set to NULL
when the mouse is released. It's almost like the events arrive out of order.
from gemrb.
I checked and managed to crash it while the button was still pressed. But yeah, it could be from the previous pair/attempt.
Didn't manage to reproduce with portrait dragging.
from gemrb.
too early to say for sure, but we should examine the possibility of the EventManager::mouseButtonFlags
variable getting out of sync with SDL.
from gemrb.
It's also not universally true that a button must be down during drag — inventory item dragging.
from gemrb.
"Inventory dragging" isn't the same. Window
is dealing with true mouse dragging (button is down followed by a movement) not a conceptual drag.
I have this mostly fixed. Looks like there is still an issue when distributing events between 2 windows. Example: mouse down inside one window then drag and release in another. the origin window will continue to think the mouse is down.
the solution is to add an implementation of Window::OnMouseLeave
and probably move some of the trackingView
code from Window::DispatchMouseMotion
there
from gemrb.
this is hopefully unrelated, but is seems that the selection rect on GameControl
no longer gets drawn.
I checked out prior to my changes and its still broken, so not sure what happened with it
from gemrb.
suspect #50.
from gemrb.
indeed. must have forgotten about that (been gone for a while if you hadn't noticed ha ha)
can we close this then?
from gemrb.
Sure. Please clear out your stashes before working on something new, so it'll be easier to work together.
from gemrb.
Related Issues (20)
- inventory: unusuable items blink the whole overlay HOT 5
- Crash on moving the cursor badly while loading HOT 5
- Crash after BG2 switch screen HOT 3
- More Efficient Text Rendering HOT 1
- SDL2: items drawn over fog HOT 5
- Map Fog drawing tanks performance HOT 5
- Convert `Point` from short -> int HOT 1
- msgwin causes optwin and/or portraitwin drawing issue HOT 8
- can't use enter to move through dialog HOT 14
- soa intro shows broken fades HOT 5
- looting the painting container reliably crashes HOT 1
- odd hotkey crash HOT 6
- rightclicking on msgwin TA shows textedit cursor HOT 3
- f1-f12 hotkeys not working for actionbar actions
- tooltip text: eating up newlines / bad width calc HOT 3
- SDL1: movement target reticles drawn incorectly
- no easy way to reset the action bar HOT 2
- trying to worldmap travel triggers an assert HOT 1
- Assertion `key.character == 0' failed HOT 1
- scroll bams not displaying in shops HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gemrb.